[PATCH] D37902: [CodeExtractor] Fix multiple bugs under certain shape of extracted region

[Jakub Kuderski via Phabricator via llvm-commits]

kuhar accepted this revision.
kuhar added a comment.
This revision is now accepted and ready to land.

Other than the two minor nits, the patch looks good to me.



================
Comment at: lib/Transforms/Utils/CodeExtractor.cpp:768
+      continue;
+    // Find proper insertion point
+    Instruction *InsertPt = OutI->getNextNode();
----------------
nit: s/point/point.


================
Comment at: lib/Transforms/Utils/CodeExtractor.cpp:771
+    // Let's assume that there is no other guy interleave
+    // non-PHI in PHIs
+    if (isa<PHINode>(InsertPt))
----------------
nit: s/PHIs/PHIs.
You can also move this piece of comment to the line above, as you won't hit the 80-column limit (I think :P).


https://reviews.llvm.org/D37902