[PATCH] D38499: [BasicAA] Fix adjustToPointerSize in BasicAliasAnalysis.cpp for ptr > 64b

[Hal Finkel via Phabricator via llvm-commits]

hfinkel added a comment.

In https://reviews.llvm.org/D38499#887512, @efriedma wrote:

> If we switch to using APInt for offsets, adjustToPointerSize() just goes away, so I don't see how this is forward progress.


Granted. There's a risk that, if we try that, we'll find an unacceptable compile-time slowdown. Nevertheless, I'll go with you on this: there are only around 40 int64_t variables in BasicAA, so it's worth trying.

> I guess the alternative is to try to add a bunch of overflow checks, but that seems a lot more complicated for no benefit.


https://reviews.llvm.org/D38499