[PATCH] D38508: AMDGPU: Expand setcc for v2i32 and v4i32

Konstantin Zhuravlyov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 3 11:54:39 PDT 2017


kzhuravl added inline comments.


================
Comment at: lib/Target/AMDGPU/SIISelLowering.cpp:186-188
+  setOperationAction(ISD::SETCC, MVT::v2i32, Expand);
+  setOperationAction(ISD::SETCC, MVT::v4i32, Expand);
   AddPromotedToType(ISD::SETCC, MVT::i1, MVT::i32);
----------------
arsenm wrote:
> Not sure how this could have been missing. Is f32 also broken? 
> 
> This should go in the vector loops in AMDGPUISelLowering with the other v2i32/v4i32 operations 
I do not think f32 is broken.


https://reviews.llvm.org/D38508





More information about the llvm-commits mailing list