[PATCH] D38497: Minor refactoring regarding Cast::isNoopCast(), NFC

Mikael Holmén via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 3 05:22:32 PDT 2017


uabelho created this revision.
Herald added a subscriber: wdng.

FastISel::hasTrivialKill() was the only user of the "IntPtrTy" version of
Cast::isNoopCast(). According to review comments in https://reviews.llvm.org/D37894 we could instead
use the "DataLayout" version of the method, and thus get rid of the
"IntPtrTy" versions of isNoopCast() completely.

With the above done, the remaining isNoopCast() could then be simplified
a bit more.


https://reviews.llvm.org/D38497

Files:
  include/llvm/IR/InstrTypes.h
  lib/CodeGen/SelectionDAG/FastISel.cpp
  lib/IR/Instructions.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D38497.117504.patch
Type: text/x-patch
Size: 4479 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20171003/4bbb660b/attachment.bin>


More information about the llvm-commits mailing list