[PATCH] D38450: ISel type legalization: add debug messages. NFC.

Sam Parker via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 3 00:26:28 PDT 2017


samparker accepted this revision.
samparker added a comment.
This revision is now accepted and ready to land.

Hi Sjoerd,

This is some good itch scratching! One comment from me, but no need to re-review. LGTM.

Thanks,
sam



================
Comment at: lib/CodeGen/SelectionDAG/LegalizeDAG.cpp:2392
 
-  // Implementation of unsigned i64 to f32.
+  DEBUG(dbgs() << "Converting unsigned i64 to f32\n");
   // TODO: Generalize this for use with other types.
----------------
I think this debug message and the one above would be more helpful contained in their corresponding if statement.


https://reviews.llvm.org/D38450





More information about the llvm-commits mailing list