[PATCH] D38482: TargetMachine: Use LLVMTargetMachine in CodeGen

Eric Christopher via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 2 19:21:03 PDT 2017


echristo added a comment.

Hi Matthias,

Similar to Chandler's comments I think we should look at folding these two together rather than keeping them split apart. I started working a little bit in this direction at one point, but admittedly got distracted by other things. A more concrete thought here is that we could either move all of the bits over into the TargetMachine and for something that doesn't need it then that target could simply just not initialize or define those initialization routines (I don't recall anything that doesn't currently need). It might end up being a bit more verbose in a couple of targets, but seems like a reasonable start.

Thoughts?

-eric


Repository:
  rL LLVM

https://reviews.llvm.org/D38482





More information about the llvm-commits mailing list