[PATCH] D38480: CodeView: Provide a .def file with the register ids

[Reid Kleckner via Phabricator via llvm-commits]

rnk added inline comments.


================
Comment at: include/llvm/DebugInfo/CodeView/CodeViewRegisters.def:240
+
+CV_REGISTER(AMD64_XMM8,  252)
+CV_REGISTER(AMD64_XMM9,  253)
----------------
hans wrote:
> rnk wrote:
> > Does anything prevent us from removing the AMD64_ prefix?
> cvconst.h has both CV_REG_YMM0 (252) and CV_AMD64_YMM0 (368).
> 
> I dropped the CV_REG_YMM* ones, because 252 is also CV_AMD64_XMM8, and with duplicate names we can't build switch cases from this.
> 
> I suppose we could drop the prefix, but I figured there's some value in being closer to the original names maybe :-/
Darn. I guess I'd say, just prefix the ones that are different for x86 vs x64. We'll need both values (eventually) if we want to support debug info of variables in YMM registers.


https://reviews.llvm.org/D38480