[PATCH] D38369: [InstSimplify] teach SimplifySelectInst() to fold more vector selects

[Haicheng Wu via Phabricator via llvm-commits]

This revision was automatically updated to reflect the committed changes.
Closed by commit rL314741: [InstSimplify] teach SimplifySelectInst() to fold more vector selects (authored by haicheng).

Changed prior to commit:
  https://reviews.llvm.org/D38369?vs=117396&id=117453#toc

Repository:
  rL LLVM

https://reviews.llvm.org/D38369

Files:
  llvm/trunk/include/llvm/Analysis/ConstantFolding.h
  llvm/trunk/lib/Analysis/InstructionSimplify.cpp
  llvm/trunk/test/Transforms/InstSimplify/select.ll


Index: llvm/trunk/lib/Analysis/InstructionSimplify.cpp
===================================================================
--- llvm/trunk/lib/Analysis/InstructionSimplify.cpp
+++ llvm/trunk/lib/Analysis/InstructionSimplify.cpp
@@ -3580,6 +3580,9 @@
   // select true, X, Y  -> X
   // select false, X, Y -> Y
   if (Constant *CB = dyn_cast<Constant>(CondVal)) {
+    if (Constant *CT = dyn_cast<Constant>(TrueVal))
+      if (Constant *CF = dyn_cast<Constant>(FalseVal))
+        return ConstantFoldSelectInstruction(CB, CT, CF);
     if (CB->isAllOnesValue())
       return TrueVal;
     if (CB->isNullValue())
Index: llvm/trunk/include/llvm/Analysis/ConstantFolding.h
===================================================================
--- llvm/trunk/include/llvm/Analysis/ConstantFolding.h
+++ llvm/trunk/include/llvm/Analysis/ConstantFolding.h
@@ -79,6 +79,12 @@
 Constant *ConstantFoldBinaryOpOperands(unsigned Opcode, Constant *LHS,
                                        Constant *RHS, const DataLayout &DL);
 
+/// \brief Attempt to constant fold a select instruction with the specified
+/// operands. The constant result is returned if successful; if not, null is
+/// returned.
+Constant *ConstantFoldSelectInstruction(Constant *Cond, Constant *V1,
+                                        Constant *V2);
+
 /// \brief Attempt to constant fold a cast with the specified operand.  If it
 /// fails, it returns a constant expression of the specified operand.
 Constant *ConstantFoldCastOperand(unsigned Opcode, Constant *C, Type *DestTy,
Index: llvm/trunk/test/Transforms/InstSimplify/select.ll
===================================================================
--- llvm/trunk/test/Transforms/InstSimplify/select.ll
+++ llvm/trunk/test/Transforms/InstSimplify/select.ll
@@ -17,6 +17,14 @@
   ret <2 x i8> %s
 }
 
+define <2 x i8> @vsel_mixedvec() {
+; CHECK-LABEL: @vsel_mixedvec(
+; CHECK-NEXT:    ret <2 x i8> <i8 0, i8 3>
+;
+  %s = select <2 x i1><i1 true, i1 false>, <2 x i8> <i8 0, i8 1>, <2 x i8> <i8 2, i8 3>
+  ret <2 x i8> %s
+}
+
 define i32 @test1(i32 %x) {
 ; CHECK-LABEL: @test1(
 ; CHECK-NEXT:    ret i32 %x


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D38369.117453.patch
Type: text/x-patch
Size: 2133 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20171002/6dc9eb11/attachment.bin>