[PATCH] D38461: [MC] - Don't assert when non-english characters are used.

Rafael Avila de Espindola via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 2 16:25:18 PDT 2017


Reid Kleckner via Phabricator <reviews at reviews.llvm.org> writes:

> rnk added a comment.
>
> cppreference suggests writing our own wrapper to avoid this issue: http://en.cppreference.com/w/cpp/string/byte/isdigit
>
> I'd suggest adding `llvm::isDigit` and `llvm::isHexDigit` in StringExtras.h next to our other hex digit conversion routines, so we don't have to repeat this surprising cast everywhere.

I agree.

Cheers,
Rafael


More information about the llvm-commits mailing list