[PATCH] D38469: CodeView symbol dumper: use symbolic names for registers

[Reid Kleckner via Phabricator via llvm-commits]

rnk added inline comments.


================
Comment at: test/DebugInfo/COFF/fp-stack.ll:15
 ; OBJ:    DefRangeRegisterSym {
-; OBJ:      Register: 128
+; OBJ:      Register: 0x80
 ; OBJ:      MayHaveNoName: 0
----------------
hans wrote:
> This one is a bit mysterious.. 128 / 0x80 is not in the RegisterId. Is the enum missing floating-point registers perhaps?
I guess it's FP0, from reading the comments in X86MCTargetDesc.cpp:
  // The x87 registers start at 128 and are numbered sequentially.
  unsigned FP0Start = 128;
  for (unsigned I = 0; I < 8; ++I)
    MRI->mapLLVMRegToCVReg(X86::FP0 + I, FP0Start + I);



https://reviews.llvm.org/D38469