[PATCH] D38462: [DebugInfo] Replace unreachable with ReportError in debug frame parser.

[Jonas Devlieghere via Phabricator via llvm-commits]

JDevlieghere added a comment.

Thanks guys, I should've given this more thought!

In https://reviews.llvm.org/D38462#885890, @rnk wrote:

> @MatzeB has proposed making `report_fatal_error` abort, which libfuzzer will re-file as a bug. Converting unreachable to report_fatal_error just kicks the actual error handling down the road.


That makes sense.

In https://reviews.llvm.org/D38462#885897, @aprantl wrote:

> Since we are working towards the goal of making libDebugInfo good enough for LLDB to use, I don't think using report_fatal_error is acceptable on invalid inputs. Could this be made so the parsing returns an optional or expected instead?


I think this is indeed the desired solution.


Repository:
  rL LLVM

https://reviews.llvm.org/D38462