[PATCH] D38184: Move the stripping of malformed debug info from the Verifier to AutoUpgrade.

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 2 09:14:05 PDT 2017


rnk added inline comments.


================
Comment at: include/llvm/AsmParser/Parser.h:39-40
 ///              parsing.
-std::unique_ptr<Module> parseAssemblyFile(StringRef Filename,
-                                          SMDiagnostic &Error,
-                                          LLVMContext &Context,
-                                          SlotMapping *Slots = nullptr);
+/// \param DisableVerifier Do not run UpgradeDebugInfo, which runs the Verifier.
+///                        Only to be used by llvm-as for testing!
+std::unique_ptr<Module>
----------------
Maybe make the parameter `UpgradeDebugInfo = true` and indicate that debug info upgrading requires verified IR?


Repository:
  rL LLVM

https://reviews.llvm.org/D38184





More information about the llvm-commits mailing list