[PATCH] D38439: AMDGPU/GlobalISel: Mark 32-bit G_FADD as legal

Kristof Beyls via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 2 02:13:51 PDT 2017


kristof.beyls added inline comments.


================
Comment at: test/CodeGen/AMDGPU/GlobalISel/legalize-fadd.mir:1
+# RUN: llc -mtriple=amdgcn-mesa-mesa3d -mcpu=fiji -run-pass=legalizer -global-isel %s -o - | FileCheck %s
+
----------------
I just find "-mcpu=fiji" a bit strange for this test - I'm a bit surprised an -mcpu would be needed here.
Otherwise, without knowing hardly anything about the AMDGPU target, the rest of this patch looks fine to me.


https://reviews.llvm.org/D38439





More information about the llvm-commits mailing list