[PATCH] D38154: [PassManager] Run global opts after the inliner

[Mehdi AMINI via Phabricator via llvm-commits]

mehdi_amini added inline comments.


================
Comment at: lib/Transforms/IPO/PassManagerBuilder.cpp:511
+    // benefits generally outweight the cost, making the whole pipeline
+    // faster. See PR34652.
+    PM.add(createGlobalOptimizerPass());
----------------
chandlerc wrote:
> mehdi_amini wrote:
> > Did you run any benchmarks to conclude that it is faster? (The referenced PR seems to only mention some specific IR generated by Rust IIUC)
> > 
> I chatted some with Davide about this on IRC and he had seen similar issues with C++. Fundamentally, I would expect the same pattern to be able to come up in C++.
OK, it'd be nice to have a test-case with this patch though.


https://reviews.llvm.org/D38154