[PATCH] D38154: [PassManager] Run global opts after the inliner

[Gor Nishanov via Phabricator via llvm-commits]

GorNishanov added inline comments.


================
Comment at: lib/Transforms/IPO/PassManagerBuilder.cpp:513
+    PM.add(createGlobalOptimizerPass());
+    PM.add(createGlobalDCEPass());
   }
----------------
davide wrote:
> efriedma wrote:
> > Are you sure this is where you meant to put these passes...?  GlobalOpt and GlobaDCE are module passes, so you're separating the inliner from the function simplification passes.
> No, you're right, they should be outside the `if` (actually, that's where I put that in the first place, then wrongly moved).
Should those be MPM.add as opposed to PM.add ?


https://reviews.llvm.org/D38154