[PATCH] D38260: [llvm-objcopy] Add support for removing sections

[Jake Ehrlich via Phabricator via llvm-commits]

jakehehrlich updated this revision to Diff 117249.
jakehehrlich added a comment.

1. I was playing with the recommended test that I said would not prove anything and it actually exposed a bunch of issues. I submitted https://reviews.llvm.org/D38436 for review and that should be landed before this is landed.
2. I made the recommended grammatical changes
3. The new test in https://reviews.llvm.org/D38436 named "segment-shift.test" is exactly the test case James recommended minus the section removal.


Repository:
  rL LLVM

https://reviews.llvm.org/D38260

Files:
  test/tools/llvm-objcopy/dynsym-error-remove-strtab.test
  test/tools/llvm-objcopy/reloc-error-remove-symtab.test
  test/tools/llvm-objcopy/remove-section-with-symbol.test
  test/tools/llvm-objcopy/remove-section.test
  test/tools/llvm-objcopy/segment-test-remove-section.test
  test/tools/llvm-objcopy/symtab-error-on-remove-strtab.test
  tools/llvm-objcopy/Object.cpp
  tools/llvm-objcopy/Object.h
  tools/llvm-objcopy/llvm-objcopy.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D38260.117249.patch
Type: text/x-patch
Size: 21566 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170930/1415dc04/attachment.bin>