[PATCH] D38260: [llvm-objcopy] Add support for removing sections
Jake Ehrlich via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Sep 29 17:30:29 PDT 2017
jakehehrlich updated this revision to Diff 117249.
jakehehrlich added a comment.
1. I was playing with the recommended test that I said would not prove anything and it actually exposed a bunch of issues. I submitted https://reviews.llvm.org/D38436 for review and that should be landed before this is landed.
2. I made the recommended grammatical changes
3. The new test in https://reviews.llvm.org/D38436 named "segment-shift.test" is exactly the test case James recommended minus the section removal.
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 21566 bytes
Desc: not available
More information about the llvm-commits