[PATCH] D38407: [ELF] - Do --hash-style=both by default.

Rafael Avila de Espindola via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 29 13:08:43 PDT 2017


In addition to that, I would probably feel more comfortable if the test
just changed the command line. It is hard to review so many test changes
to see that they still test the desired property.

Cheers,
Rafael


Rui Ueyama via Phabricator <reviews at reviews.llvm.org> writes:

> ruiu added a comment.
>
> Could you start a thread in the mailing list to propose a change of the default settings first then create a patch?
>
> I don't want you to update that many tests (which probably needed a lot of labor work) before getting any consensus, even if reaching a consensus is obvious to you. A rule of thumb is that, code review is not a place to discuss policy changes.
>
>
> https://reviews.llvm.org/D38407


More information about the llvm-commits mailing list