[PATCH] D38419: Rename instruction classes for memory intrinsics. (NFC)

Daniel Neilson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 29 13:02:05 PDT 2017


dneilson added a comment.

In https://reviews.llvm.org/D38419#884865, @hfinkel wrote:

> In https://reviews.llvm.org/D38419#884799, @dneilson wrote:
>
> > Pulling this, for now. I'm going to make sure that the joint part of the hierarchy (i.e. the AnyMem* classes) will work before trying to land this part.
>
>
> FWIW, I don't really like the PainMem* names, although the AtomicMem* looks like an improvement. Can't you just leave the plain ones alone?


I have no particular objection to leaving the plain ones as is. It's what I suggested: http://lists.llvm.org/pipermail/llvm-dev/2017-August/116716.html

A counter suggestion, that wasn't challenged was made to change the plain ones as well: http://lists.llvm.org/pipermail/llvm-dev/2017-August/116722.html


https://reviews.llvm.org/D38419





More information about the llvm-commits mailing list