[PATCH] D38384: [InstCombine] Don't use Builder.getTrue/False in foldICmpDivConstant

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 29 11:37:22 PDT 2017


spatel added a comment.

This looks similar to a block of code we have for foldOrOfICmps(). We can fold some cases to constants (so InstSimplify should get those), but some cases just become different compares.

Can we assert instead? In foldOrOfICmps(), it looks like:

  assert(!RHSC->isMaxValue(false) && "Missed icmp simplification");


https://reviews.llvm.org/D38384





More information about the llvm-commits mailing list