[PATCH] D38390: [builtins] ARM: Reland fix for assembling builtins in thumb state.
Peter Smith via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Sep 29 10:27:06 PDT 2017
peter.smith added a comment.
I've made one suggestion for the comment, but otherwise looks ok to me.
Comment at: lib/builtins/arm/aeabi_cdcmp.S:49
// NaN has been ruled out, so __aeabi_cdcmple can't trap
+ // Use "it ne" to avoid watchos thumb assembly issue (PR 34768).
I think that the comment could be a bit more specific to the issue without needing to link to the pr.
For example "On some builds __aeabi_cdcmple may be in a different section so we use an IT followed by an unconditional branch to guarantee that we have a supported relocation on all platforms."
More information about the llvm-commits