[PATCH] D37758: [AMDGPU] For amdpal, widen interpolation mode workaround

Nicolai Hähnle via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 29 08:28:48 PDT 2017


nhaehnle added inline comments.


================
Comment at: lib/Target/AMDGPU/SIISelLowering.cpp:1511-1517
+      unsigned PsInputBits = Info->getPSInputAddr() & Info->getPSInputEnable();
+      if ((PsInputBits & 0x7F) == 0 ||
+          ((PsInputBits & 0xF) == 0 &&
+           (PsInputBits >> 11 & 1)))
+        Info->markPSInputEnabled(
+            countTrailingZeros(Info->getPSInputAddr(), ZB_Undefined));
     }
----------------
Could you make this guarded by isAmdPalOS? For Mesa, it's possible that another shader part will enable some of those input bits, so we want to set those enables only after the combined enable mask is known.


https://reviews.llvm.org/D37758





More information about the llvm-commits mailing list