[PATCH] D38312: adding pattern for broadcastm

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon added inline comments.


================
Comment at: test/CodeGen/X86/broadcastm-lowering.ll:3
+; RUN: llc < %s -mtriple=x86_64-unknown-unknown -mcpu=skx  | FileCheck %s --check-prefix=ALL --check-prefix=SKX
+; RUN: llc < %s -mtriple=x86_64-unknown-unknown -mcpu=knl  | FileCheck %s --check-prefix=ALL --check-prefix=KNL
+
----------------
zvi wrote:
> RKSimon wrote:
> > Please don't use -mcpu, use -mattr instead. Something like:
> > ```
> > ; RUN: llc < %s -mtriple=x86_64-unknown-unknown -mcpu=+avx512f | FileCheck %s --check-prefix=ALL --check-prefix=AVX512F
> > ; RUN: llc < %s -mtriple=x86_64-unknown-unknown -mattr=+avx512vl,+avx512dq  | FileCheck %s --check-prefix=ALL --check-prefix=AVX512DQVL
> > ```
> > 
> > Also, should i686 triples be tested as well? Not sure if any non-legal i64 issues will arise
> Simon has already mentioned this
Please can you tidy the prefixes: AVX512CD, AVX512VLCDBW and X86-AVX512VLCDBW would be more closely match convention.


https://reviews.llvm.org/D38312