[PATCH] D38215: [SelectionDAG] Fix ATOMIC_CMP_SWAP_WITH_SUCCESS expansion

Ulrich Weigand via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 29 02:29:04 PDT 2017


uweigand added a comment.

Note that as of r314428 I've switched the SystemZ back-end to use a custom expander for ATOMIC_CMP_SWAP_WITH_SUCCESS, which makes use of the condition code value set by the compare-and-swap hardware instruction to completely omit any extra comparison.

The common-code expander is no longer used at all on SystemZ, therefore this bug in that code no longer really matters to us.   I guess it should still be fixed, in case other platforms run into the issue ...


https://reviews.llvm.org/D38215





More information about the llvm-commits mailing list