[PATCH] D38201: Use a BumpPtrAllocator for Loop objects

Sanjoy Das via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 28 18:50:24 PDT 2017


I think Benjamin Kramer already fixed this by rL314418.  Do you mind
taking retrying on ToT?

-- Sanjoy

On Thu, Sep 28, 2017 at 6:40 PM, Aditya Nandakumar
<aditya_nandakumar at apple.com> wrote:
> Hi Sanjay,
>
> This change is causing some ASAN issues about use after poison. Attached here is a bug point reduced test case. Could you please revert this commit and take a look?
>
>
>
> opt -loop-unroll simplified.ll crashes for me.
>
> Aditya
>> On Sep 27, 2017, at 7:47 PM, Sanjoy Das via Phabricator via llvm-commits <llvm-commits at lists.llvm.org> wrote:
>>
>> This revision was automatically updated to reflect the committed changes.
>> Closed by commit rL314375: Use a BumpPtrAllocator for Loop objects (authored by sanjoy).
>>
>> Changed prior to commit:
>>  https://reviews.llvm.org/D38201?vs=116907&id=116916#toc
>>
>> Repository:
>>  rL LLVM
>>
>> https://reviews.llvm.org/D38201
>>
>> Files:
>>  llvm/trunk/include/llvm/Analysis/LoopInfo.h
>>  llvm/trunk/include/llvm/Analysis/LoopInfoImpl.h
>>  llvm/trunk/include/llvm/Analysis/LoopPass.h
>>  llvm/trunk/include/llvm/CodeGen/MachineLoopInfo.h
>>  llvm/trunk/include/llvm/IR/PassManager.h
>>  llvm/trunk/include/llvm/Support/Allocator.h
>>  llvm/trunk/include/llvm/Transforms/Scalar/LoopPassManager.h
>>  llvm/trunk/lib/Analysis/CGSCCPassManager.cpp
>>  llvm/trunk/lib/Analysis/LoopAnalysisManager.cpp
>>  llvm/trunk/lib/Analysis/LoopInfo.cpp
>>  llvm/trunk/lib/Analysis/LoopPass.cpp
>>  llvm/trunk/lib/Transforms/IPO/Inliner.cpp
>>  llvm/trunk/lib/Transforms/IPO/LoopExtractor.cpp
>>  llvm/trunk/lib/Transforms/Scalar/InductiveRangeCheckElimination.cpp
>>  llvm/trunk/lib/Transforms/Scalar/LoopDeletion.cpp
>>  llvm/trunk/lib/Transforms/Scalar/LoopUnrollPass.cpp
>>  llvm/trunk/lib/Transforms/Scalar/LoopUnswitch.cpp
>>  llvm/trunk/lib/Transforms/Utils/CloneFunction.cpp
>>  llvm/trunk/lib/Transforms/Utils/LoopSimplify.cpp
>>  llvm/trunk/lib/Transforms/Utils/LoopUnroll.cpp
>>  llvm/trunk/lib/Transforms/Vectorize/LoopVectorize.cpp
>>  llvm/trunk/test/Transforms/LoopUnroll/unroll-loop-invalidation.ll
>>  llvm/trunk/unittests/Transforms/Scalar/LoopPassManagerTest.cpp
>>
>> <D38201.116916.patch>_______________________________________________
>> llvm-commits mailing list
>> llvm-commits at lists.llvm.org
>> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
>


More information about the llvm-commits mailing list