[PATCH] D38374: [memcpyopt] Memcpy-memcpy dependence isn't detected across basic blocks

Daniel Berlin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 28 18:41:02 PDT 2017


dberlin added a comment.

So, if the work is done (I think you would have to change some getDefiningAccess calls to getClobberingAccess), and it works, i'd prefer for us to just do that and declare victory.
If it's *not* done, okay, fine, that sucks but not gonna hold up the world here.

Everyone always wants to just do the small change they want,  You know this.
Part of doing the review is to say "well, that's nice, but we should make sure that's really a good thing for llvm as a whole".
Otherwise, tragedy of the commons and all that.
So i'd like to understand if the other patch solves your problem before i approve this one.


Repository:
  rL LLVM

https://reviews.llvm.org/D38374





More information about the llvm-commits mailing list