[PATCH] D38379: First (real) implementation of llvm-cfi-verify.

[Vlad Tsyrklevich via Phabricator via llvm-commits]

vlad.tsyrklevich requested changes to this revision.
vlad.tsyrklevich added a comment.
This revision now requires changes to proceed.

This commit is hard to understand in it's totality and seems like it could be broken up into a couple of smaller changes. First off, the current llvm-verify-cfi.cpp could be refactored into the current FileVerifier interface without any of the new functionality. Next you could add functionality and tests for building CFGs, and then finally the CFI functionality built on top of that. Also, with that in mind, does it make sense to mix-up FileVerifier with the CFG construction logic? Those seem like they should be logically separate, possibly with some form state object passed between them to encapsulate the private members of FileVerifier?


https://reviews.llvm.org/D38379