[PATCH] D38368: [dwarfdump][NFC] Consistent errors and warnings with --verify

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added a comment.

Sweet.
And then we can add color (using the same color scheme as clang with -fcolor-diagnostics) when printing to a real TTY (there already is code in dwarfdump to detect this).

Are there errors/warnings outside of `DWARFVerifier.cpp`, too?



================
Comment at: lib/DebugInfo/DWARF/DWARFVerifier.cpp:154
     if (!ValidLength)
-      OS << "\tError: The length for this unit is too "
+      OS << "\tThe length for this unit is too "
             "large for the .debug_info provided.\n";
----------------
in the compiler we often prefix additional comments with `note: `. Should we do this here, too? (with a `note() <<` function?


Repository:
  rL LLVM

https://reviews.llvm.org/D38368