[PATCH] D37810: [test] Enable LeakSanitizer on 64-bit Darwin ASan clang builds

[Francis Ricci via Phabricator via llvm-commits]

fjricci added a comment.

@kubamracek and I had a discussion about this here: https://reviews.llvm.org/D35443

I think the issue boils down to complexities in objective-C and swift code, and their associated system libraries. LeakSanitizer works well on C++ code (as evidenced by the lack of false positives in the llvm and clang test suites), but I don't personally have the bandwidth to ensure the same goes for objective-C and swift code, particularly due to the fact that many objective-C system APIs are opaque and tough to deal with as someone without access to the source code (stashing pointers in mmap'd pages etc).

LeakSanitizer for Darwin is also fairly new (I finished the implementation within the last couple months), which is why this hasn't been considered before.

There's also a performance/value consideration, LeakSanitizer doesn't impact performance significantly (and has about the same impact on Darwin as it does on Linux), but it still does come with some overhead, and it seems reasonable to allow ASan users to decide whether or not it's a feature they'd like to use.


https://reviews.llvm.org/D37810