[PATCH] D38363: [dwarfdump] Verify that CUs have a unit DIE.

Adrian Prantl via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 28 08:34:16 PDT 2017

aprantl accepted this revision.
aprantl added inline comments.
This revision is now accepted and ready to land.

Comment at: lib/DebugInfo/DWARF/DWARFVerifier.cpp:186
+  } else {
+    OS << "Error: Compilation unit without unit DIE.\n";
+    NumUnitErrors++;
I think we always call this "error: " in lowercase to match compiler error formatting.

Side note: I think it would be good to introduce something similar to the error() function in tools/dsymutil/DwarfLinker.cpp so we don't duplicate the "error: " and "warning: " strings a hundred times.



More information about the llvm-commits mailing list