[PATCH] D38137: [ELF] Simpler scheme for handling common symbols

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 27 21:52:53 PDT 2017


ruiu added inline comments.


================
Comment at: ELF/MarkLive.cpp:224-225
         Enqueue(IS, D->Value);
       return;
     }
   };
----------------
Since you have removed the following code, you can remove this `return`.

  auto MarkSymbol = [&](SymbolBody *Sym) {
    if (auto *D = dyn_cast_or_null<DefinedRegular>(Sym))
      if (auto *Sec = cast_or_null<InputSectionBase>(D->Section))
        Enqueue(Sec, D->Value);
  };


https://reviews.llvm.org/D38137





More information about the llvm-commits mailing list