[PATCH] D38337: Check for overflows when calculating the offset in GetGEPCost.

[Justin Lebar via Phabricator via llvm-commits]

jlebar added a comment.

Thank you for the review, Eli.



================
Comment at: llvm/include/llvm/Analysis/TargetTransformInfoImpl.h:681
+    // this function.
+    APInt BaseOffset(/*numbits=*/64, 0);
     int64_t Scale = 0;
----------------
efriedma wrote:
> Should we use the pointer width here, rather than the constant "64"?
Looking at the langref, I think you're right, here and below.  I've updated the patch, wdyt?


https://reviews.llvm.org/D38337