[PATCH] D38298: A logic to copy LLVM licences into docker images.

[Mehdi AMINI via Phabricator via llvm-commits]

mehdi_amini added a comment.

In https://reviews.llvm.org/D38298#881699, @ilya-biryukov wrote:

> In https://reviews.llvm.org/D38298#881628, @mehdi_amini wrote:
>
> > Can you elaborate why this script is desirable/needed?
>
>
> Sure, sorry for leaving out the context.
>
> Including licences is technically required in any binary distribution of LLVM, including ones inside Docker images.
>  Copying the licenses could be made optional, but always putting the licenses into Docker images should not hurt either.


OK, but why is this logic applicable to clang/llvm built with the docker script and not for any build?

It seems to me that if this is deemed useful/necessary, that should be part of `make install` and controlled by a CMake flag (`-DLLVM_INSTALL_LICENCES=ON`) which could be enabled by default or not.

Docker is great for managing dependencies and providing build reproducibility: it is great to provide scripts that makes it easier to use to build clang/LLVM. However I'm worried about embedding any information in these scripts about build / release / packaging that wouldn't be Docker specific.


https://reviews.llvm.org/D38298