[PATCH] D38085: Use the basic cost if a GEP is not used as addressing mode

[Hal Finkel via Phabricator via llvm-commits]

hfinkel added inline comments.


================
Comment at: include/llvm/Analysis/TargetTransformInfoImpl.h:734
+      // FIXME: GEPs could also be folded away as a part of addressing mode in
+      // load/store instructions togetehr with other instructions (e.g., sext or
+      // other GEPs). Handling all such cases must be expensive to be performed
----------------
togetehr -> together


================
Comment at: include/llvm/Analysis/TargetTransformInfoImpl.h:736
+      // other GEPs). Handling all such cases must be expensive to be performed
+      // in this function, so we stay conservative for now.
+      for (const User *U : GEP->users()) {
----------------
I don't understand this comment. If there's a sext/zext, then it would be an operand of the GEP, not the other way around, no?


https://reviews.llvm.org/D38085