[PATCH] D38281: [llvmlab] Add timeout and retries for fetching builds.

[Volodymyr Sapsai via Phabricator via llvm-commits]

vsapsai added inline comments.


================
Comment at: llvmbisect/llvmlab/gcs.py:53
              'prefix': project + "/"}
-    r = requests.get(GCS + "b/" + BUCKET + "/o", params=params)
+    http = HttpClient()
+    r = http.get(GCS + "b/" + BUCKET + "/o", params=params)
----------------
JDevlieghere wrote:
> Any argument against moving this up and having all the functions reusing this single instance? 
No argument against it. I'll move and test.

`HttpClient` was intended to be stateful so I tried to avoid sharing. But based on current implementation we can safely share it and if necessary, it is possible to have a separate client.


https://reviews.llvm.org/D38281