[PATCH] D38319: [ELF] - Teach ICF to take FDEs into account when doing code folding.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 27 08:46:44 PDT 2017


grimar created this revision.
Herald added a subscriber: emaste.

ICF currently does not take in account data stored in FDEs.
That means if we have 2 "identical" code sections, but one
of them does not have frame data associated or both of them has
different data, code still be folded, what is not correct.

Patch does the first step to improve the situation. It teaches ICF
to compare data stored in FDEs as well, so that only sections
that have equal FDEs are eligible to be merged.


https://reviews.llvm.org/D38319

Files:
  ELF/Driver.cpp
  ELF/EhFrame.cpp
  ELF/EhFrame.h
  ELF/ICF.cpp
  ELF/InputSection.h
  ELF/SyntheticSections.cpp
  ELF/SyntheticSections.h
  ELF/Writer.cpp
  test/ELF/eh-frame-hdr-icf-fde1.s
  test/ELF/eh-frame-hdr-icf-fde2.s
  test/ELF/eh-frame-hdr-icf-fde3.s
  test/ELF/eh-frame-hdr-icf.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D38319.116819.patch
Type: text/x-patch
Size: 11291 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170927/c5dadfad/attachment.bin>


More information about the llvm-commits mailing list