[PATCH] D38193: Pre compute the tail of the archive

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added inline comments.


================
Comment at: lib/Object/ArchiveWriter.cpp:254
+  std::vector<unsigned> Symbols;
+  StringRef Header;
+  StringRef Data;
----------------
It looks like you are using StringSaver only to save this member contents. You may be able to remove StringSaver if you change this to std::string.


https://reviews.llvm.org/D38193