[PATCH] D38182: test-suite: add cpu features detection in configuration

Matthias Braun via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 26 15:31:42 PDT 2017


MatzeB added a comment.

This looks mostly fine.

- What about cross compilation scenarios? I think this should have a way to manually set the flags in that case.
- We need equivalent tests on the cmake side.
- This should only be committed when we have some tests that actually use it.



================
Comment at: autoconf/m4/get_cpu_target.m4:54
+
+AC_DEFUN([CHECK_FEATURES],
+ [m4_foreach_w(
----------------
This should have X86 in the name, and probably shouldn't even do anything if the target triple isn't x86.


https://reviews.llvm.org/D38182





More information about the llvm-commits mailing list