[PATCH] D37788: [ARM] builtins: Do not abort in clear_cache.
Saleem Abdulrasool via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Sep 26 15:31:32 PDT 2017
compnerd added a comment.
Ugh, this is not particularly helpful. I think that in the case that we can detect the failure, it would be nice. OTOH, I agree that these functions are special (effectively to be treated as if the compiler had emitted them inline). I think that having a guarded way to actually keep the abort is nice ... maybe an `assert(start_reg == 0 && "syscall failed");` instead. That would just get pulled out in the case of a `_NDEBUG` build.
@peter.smith I don't think that the "kernel" here would be anything other than Linux. If the kernel version is missing the reporting, that is a different issue.
As an aside, it sounds like although this is a pain to debug, it may actually be identifying a real issue? (which is a good reason to keep it around).
More information about the llvm-commits