[PATCH] D38240: [dwarfdump] Add support for -debug-line=OFFSET

[Jonas Devlieghere via Phabricator via llvm-commits]

JDevlieghere added a comment.

In https://reviews.llvm.org/D38240#880211, @aprantl wrote:

> Without having checked out API yet — this is still traversing over all CUs to find the one with the entry. This could be slow for something like clang.dSYM. Is there a way to find the one CU containing the entry quicker? If not, this LGTM.


Except for the address byte size (for which other parts of the code use the hack below), we only need the offset.

  uint8_t savedAddressByteSize = 0;
  // FIXME: This seems sketchy.
  for (const auto &CU : compile_units()) {
    savedAddressByteSize = CU->getAddressByteSize();
    break;
  }

But that leaves us with the same issues as mentioned in https://reviews.llvm.org/D38237: we run into trouble when passing an invalid offset.


Repository:
  rL LLVM

https://reviews.llvm.org/D38240