[PATCH] D37268: Invalidate symbolizer module list from dlopen/dlclose interceptors

[Francis Ricci via Phabricator via llvm-commits]

fjricci added inline comments.


================
Comment at: lib/sanitizer_common/sanitizer_common_interceptors.inc:5579
   void *res = REAL(dlopen)(filename, flag);
+  Symbolizer::GetOrInit()->InvalidateModuleList();
   COMMON_INTERCEPTOR_LIBRARY_LOADED(filename, res);
----------------
eugenis wrote:
> This would not spawn addr2line or llvm-symbolizer process right away?
The symbolizer process is launched by StartSymbolizerProcess(), which is only launched by SendCommand(), which is invoked by SymbolizePC() and and SymbolizeData(), so I believe this will be fine. I'll run a test and look for a symbolizer process before merging though.


================
Comment at: lib/sanitizer_common/sanitizer_symbolizer_libcdep.cc:185
     modules_fresh_ = false;
     return FindModuleForAddress(address);
   }
----------------
eugenis wrote:
> This recursion will be removed in the followup change, right?
Correct.


https://reviews.llvm.org/D37268