[PATCH] D37932: [DebugInfo] Correctly coalesce DBG_VALUEs that mix direct and indirect values

[David Blaikie via Phabricator via llvm-commits]

dblaikie added inline comments.


================
Comment at: llvm/lib/CodeGen/LiveDebugVariables.cpp:119-122
+  bool operator==(const DbgValueLocation &O) const {
+    return LocNo == O.LocNo && WasIndirect == O.WasIndirect;
+  }
+  bool operator!=(const DbgValueLocation &O) const { return !(*this == O); }
----------------
Generally, binary op overloads should be non-members (they can be friends though, which can be defined inline) to ensure equal conversions are possible on both sides of the operand.


https://reviews.llvm.org/D37932