[PATCH] D30529: [RFC][GlobalISel] Enable legalizing non-power-of-2 sized types.

Quentin Colombet via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 25 12:57:12 PDT 2017


Thanks for the update. Sounds good!

> On Sep 25, 2017, at 12:46 PM, Kristof Beyls via Phabricator <reviews at reviews.llvm.org> wrote:
> 
> kristof.beyls added a comment.
> 
> In https://reviews.llvm.org/D30529#880298, @qcolombet wrote:
> 
>> Hi Kristof,
>> 
>> I was under the impression that the patch is good to land, at least as a first step.
>> What are we missing to push this change?
>> 
>> Cheers,
>> -Quentin
> 
> 
> Hi Quentin,
> 
> This should indeed not need much more work to land. I just need to find a bit of time to:
> 
> - rebase to ToT.
> - address the few minor remarks made by Tim during review, which shouldn't be hard.
> - do some basic correctness testing and ideally compile time impact on the test-suite.
> 
> I've been hoping to push on with the above for a little while now, but have failed so far with more urgent stuff popping up all the time....
> I hope to make progress on this this week....
> 
> Thanks,
> 
> Kristof
> 
> 
> https://reviews.llvm.org/D30529
> 
> 
> 



More information about the llvm-commits mailing list