[PATCH] D37262: The issues with X86 prefixes: step 2

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 25 12:03:14 PDT 2017


craig.topper requested changes to this revision.
craig.topper added a comment.
This revision now requires changes to proceed.

The new test cases don't test anything because they aren't running FileCheck.



================
Comment at: test/MC/Disassembler/X86/prefixes-i386.s:1
+// RUN: llvm-mc -disassemble %s -triple=i386-apple-darwin9
+
----------------
This needs to be named .txt not .s

You also need to pass the output to FileCheck


================
Comment at: test/MC/Disassembler/X86/prefixes-x86_64.s:1
+// RUN: llvm-mc -disassemble %s -triple=x86_64-apple-darwin9
+
----------------
This file needs be named .txt not .s

You also need to pass the output to FileCheck


https://reviews.llvm.org/D37262





More information about the llvm-commits mailing list