[PATCH] D37882: ubsan: Unbreak ubsan_cxx runtime library on Windows.

Francis Ricci via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 25 11:36:38 PDT 2017


fjricci added a comment.

Looks like this change changes the user-visible configuration option for cxxabi from `SANITIZER_CAN_USE_CXXABI` to `SANITIZER_ALLOW_CXXABI`. Was this intentional/useful? It's not necessarily problematic, but it does cause some annoyances related to maintaining separate build options across compiler-rt branches (5.0 requires `SANITIZER_CAN_USE_CXXABI` and will not respect `SANITIZER_ALLOW_CXXABI`, and vice-versa for master/6.0).


Repository:
  rL LLVM

https://reviews.llvm.org/D37882





More information about the llvm-commits mailing list