[PATCH] D37686: [DAG] Consolidating Instruction->SDNode Flags propagation in one class for better code management.

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 25 09:26:39 PDT 2017


spatel added a comment.

In https://reviews.llvm.org/D37686#879590, @jbhateja wrote:

> @spatel , @reviewiews , can this land now into trunk ?


I haven't actually looked at the builder changes since you revised them, so I defer to @hfinkel is he's already approved that part.

I still don't understand why we should put the combiner changes into this patch. I'd like to see progress on using the flags too, but I think those should be separate patches with tests that cover all of the potential ambiguity that we've raised here.


https://reviews.llvm.org/D37686





More information about the llvm-commits mailing list