[PATCH] D38197: [DebugInfo] Sort the SDDbgValue list before assuming it is in IR order

Karl-Johan Karlsson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 25 05:04:36 PDT 2017


Ka-Ka added inline comments.


================
Comment at: llvm/test/DebugInfo/X86/dbg-value-transfer-order.ll:27-39
+; CHECK .LBB0_1:                                # %while.body
+; CHECK         movl    $32, %ecx
+; CHECK         testl   {{.*}}
+; CHECK         jne     .LBB0_3
+; CHECK # BB#2:                                 # %if.then
+; CHECK         callq   if_then
+; CHECK         movl    %eax, %ecx
----------------
I had problem recreating the fault as this testcase passed both with or without your changes in ScheduleDAGSDNodes.cpp, but then I realized that the checks in these lines don't check anything as they are missing a ':' after the CHECK.



https://reviews.llvm.org/D38197





More information about the llvm-commits mailing list