[PATCH] D38008: [llvm-objcopy] Refactor code to include initialize method

Jake Ehrlich via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 25 05:03:35 PDT 2017


jakehehrlich added inline comments.


================
Comment at: tools/llvm-objcopy/Object.h:60
   virtual ~SectionBase() {}
+  virtual void initialize(SectionTableRef Obj);
   virtual void finalize();
----------------
jhenderson wrote:
> Not sure "Obj" is the right argument name here! See also all the overrides.
Yep. That was leftover with my playing around with how this should work. I believe I originally tried passing the whole object


Repository:
  rL LLVM

https://reviews.llvm.org/D38008





More information about the llvm-commits mailing list