[compiler-rt] r314001 - Fix windows buildbot broken by r313999

[Francis Ricci via llvm-commits]

Yeah I think that's reasonable. I'll add MemoryMappingLayoutData to
sanitizer_fuchsia.h to fix the build for now, and then refactor
GetMemoryProfile and whatever else is needed by windows/fuchsia and
remove it.

On Fri, Sep 22, 2017 at 3:10 PM, Vitaly Buka <vitalybuka at google.com> wrote:
> Yeah. Now I see why original mmap approach could be better.
> Still I don't see this as a big issue. So up you, to fix same way or return
> back to dynamic allocations.
>
>
> Also real problem here that platforms which do not care about
> MemoryMappingLayoutData need to include header for other purpose.
> So maybe move GetMemoryProfile into common. Then guard entire
> sanitizer_procmaps.h with SANITIZER_POSIX, and now win and fuchsia will not
> need that header and MemoryMappingLayoutData at all.
>
>
> On Fri, Sep 22, 2017 at 11:38 AM, Francis Ricci <francisjricci at gmail.com>
> wrote:
>>
>> I could fix that the same way I fixed windows, but that starts to look
>> a bit hacky. What do you think? (We could also revert and try to
>> figure something else out)
>>
>> On Fri, Sep 22, 2017 at 2:34 PM, Vitaly Buka <vitalybuka at google.com>
>> wrote:
>> > I suspect Fuchsia is still broken
>> >
>> > On Fri, Sep 22, 2017 at 11:17 AM, Francis Ricci via llvm-commits
>> > <llvm-commits at lists.llvm.org> wrote:
>> >>
>> >> Author: fjricci
>> >> Date: Fri Sep 22 11:17:26 2017
>> >> New Revision: 314001
>> >>
>> >> URL: http://llvm.org/viewvc/llvm-project?rev=314001&view=rev
>> >> Log:
>> >> Fix windows buildbot broken by r313999
>> >>
>> >> Modified:
>> >>     compiler-rt/trunk/lib/sanitizer_common/sanitizer_procmaps.h
>> >>     compiler-rt/trunk/lib/sanitizer_common/sanitizer_win.h
>> >>
>> >> Modified: compiler-rt/trunk/lib/sanitizer_common/sanitizer_procmaps.h
>> >> URL:
>> >>
>> >> http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/sanitizer_common/sanitizer_procmaps.h?rev=314001&r1=314000&r2=314001&view=diff
>> >>
>> >>
>> >> ==============================================================================
>> >> --- compiler-rt/trunk/lib/sanitizer_common/sanitizer_procmaps.h
>> >> (original)
>> >> +++ compiler-rt/trunk/lib/sanitizer_common/sanitizer_procmaps.h Fri Sep
>> >> 22
>> >> 11:17:26 2017
>> >> @@ -19,6 +19,7 @@
>> >>  #include "sanitizer_linux.h"
>> >>  #include "sanitizer_mac.h"
>> >>  #include "sanitizer_mutex.h"
>> >> +#include "sanitizer_win.h"
>> >>
>> >>  namespace __sanitizer {
>> >>
>> >>
>> >> Modified: compiler-rt/trunk/lib/sanitizer_common/sanitizer_win.h
>> >> URL:
>> >>
>> >> http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/sanitizer_common/sanitizer_win.h?rev=314001&r1=314000&r2=314001&view=diff
>> >>
>> >>
>> >> ==============================================================================
>> >> --- compiler-rt/trunk/lib/sanitizer_common/sanitizer_win.h (original)
>> >> +++ compiler-rt/trunk/lib/sanitizer_common/sanitizer_win.h Fri Sep 22
>> >> 11:17:26 2017
>> >> @@ -20,6 +20,7 @@
>> >>  namespace __sanitizer {
>> >>  // Check based on flags if we should handle the exception.
>> >>  bool IsHandledDeadlyException(DWORD exceptionCode);
>> >> +struct MemoryMappingLayoutData {};
>> >>  }  // namespace __sanitizer
>> >>
>> >>  #endif  // SANITIZER_WINDOWS
>> >>
>> >>
>> >> _______________________________________________
>> >> llvm-commits mailing list
>> >> llvm-commits at lists.llvm.org
>> >> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>> >
>> >
>
>