[PATCH] D38170: [ELF] - Drop SHF_LINK_ORDER flag from output.

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 22 11:00:08 PDT 2017


ruiu added inline comments.


================
Comment at: ELF/Driver.cpp:976
 
+static void scanLinkOrder() {
+  for (InputSectionBase *S : InputSections) {
----------------
This is not something I meant by "drop it early when it is processed". It just drops the flag at an arbitrary point instead of when SHF_LINK_ORDER is processed. Also, this kind of code shouldn't be in the driver.


https://reviews.llvm.org/D38170





More information about the llvm-commits mailing list