[PATCH] D38129: [ELF] - Speedup -r and --emit-relocs

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 22 07:19:58 PDT 2017


grimar added a comment.

In https://reviews.llvm.org/D38129#877829, @ruiu wrote:

> Honestly this doesn't look good. I cannot point out how you can improve it at the moment, but your new helper functions handle too low-level things. Such details shouldn't be leaked here.


What do you think about new version ? It incapsulates all low level logic inside SymbolTableSection class.


https://reviews.llvm.org/D38129





More information about the llvm-commits mailing list